This repository was archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 476
This repository was archived by the owner on Nov 1, 2022. It is now read-only.
Review notes on component strings.xml files #2428
Copy link
Copy link
Closed
Labels
P1🌐 L10NLocalization, translation, strings, ..Localization, translation, strings, ..🐉 FenixFeature needed for FenixFeature needed for Fenix
Milestone
Description
@flodolo found a couple of nits when doing a review of mozilla-l10n/android-l10n#3.
Copying them over to get traction on them.
We'd like to have better comments on:
What's %s?
android-components/components/browser/engine-system/src/main/res/values/strings.xml
Line 7 in f2fc6a0
| <string name="mozac_browser_engine_system_alert_title">The page at %1$s says:</string> |
| <string name="mozac_ui_tabcounter_description">Tab Counter</string> |
Proper apostrophe in
android-components/components/feature/sitepermissions/src/main/res/values/strings.xml
Lines 37 to 42 in f2fc6a0
| <!-- Text for a negative button in a permission request dialog, this button will do not give | |
| access to this permission--> | |
| <string name="mozac_feature_sitepermissions_not_allow">Don\'t allow</string> | |
| <!-- Text for a checkbox in a permission request dialog, this will allow to not show again the prompt--> | |
| <string name="mozac_feature_sitepermissions_do_not_ask_again_on_this_site">Don\'t ask again on this site</string> |
Adding both here, @Delphine filed #2426 for the second one.
@flodolo, did you have more?
┆Issue is synchronized with this Jira Task
Metadata
Metadata
Labels
P1🌐 L10NLocalization, translation, strings, ..Localization, translation, strings, ..🐉 FenixFeature needed for FenixFeature needed for Fenix