Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Review notes on component strings.xml files #2428

@Pike

Description

@Pike

@flodolo found a couple of nits when doing a review of mozilla-l10n/android-l10n#3.

Copying them over to get traction on them.

We'd like to have better comments on:

What's %s?

<string name="mozac_browser_engine_system_alert_title">The page at %1$s says:</string>

<string name="mozac_ui_tabcounter_description">Tab Counter</string>

Proper apostrophe in

<!-- Text for a negative button in a permission request dialog, this button will do not give
access to this permission-->
<string name="mozac_feature_sitepermissions_not_allow">Don\'t allow</string>
<!-- Text for a checkbox in a permission request dialog, this will allow to not show again the prompt-->
<string name="mozac_feature_sitepermissions_do_not_ask_again_on_this_site">Don\'t ask again on this site</string>

Adding both here, @Delphine filed #2426 for the second one.

@flodolo, did you have more?

┆Issue is synchronized with this Jira Task

Metadata

Metadata

Assignees

Labels

P1🌐 L10NLocalization, translation, strings, ..🐉 FenixFeature needed for Fenix

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions