Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Conversation

@mhammond
Copy link
Contributor

This is a simple WIP which creates a simple "places" component. It's very thin as code which currently lives in the application-services repo hasn't been copied here yet - see ./components/service/sync-places/README.md for more information.

This has been created primarily so a related PR in reference-browser makes sense and can be reproduced. We'll work with the a-c team to bash this into better shape soon.

@mhammond mhammond requested a review from a team as a code owner October 19, 2018 04:40
Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general shape of this looks right to me!


servoImplementation project(':browser-engine-servo')

implementation project(':service-sync-places')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sync-logins we have a separate sample app. We'd likely not add all sync features to the sample browser, I think. So, we'd have a sync specific sample app and the reference-browser (having all features.)

@grigoryk
Copy link
Contributor

I think this looks fine. This is essentially a syncing counter-part to core-storage-local proposed in #1155. It'll be nice to have consistent naming. Maybe core-storage-sync?

As functionality for which we'd like to have multiple implementations is identified - such as the BrowserAutocompleteProvider you implement in mozilla-mobile/reference-browser#28 - that could be reified in a concept in a-c speak (an interface, with concrete browser-* components being defined in terms of that interface as opposed to concrete implementations). The HistoryTrackingDelegate interface from the engine concept is an example of this.

So this is likely to end up being split into two streams - a concept side which describes something like a "source of autocomplete data for the awesomebar", and concrete implementations here, in the local storage component, etc.

@pocmo
Copy link
Contributor

pocmo commented Oct 31, 2018

Closing in favor of #1240

@pocmo pocmo closed this Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants