Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Conversation

@grigoryk
Copy link
Contributor


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #6801 into master will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6801      +/-   ##
============================================
- Coverage     77.52%   77.46%   -0.06%     
- Complexity     4629     4659      +30     
============================================
  Files           620      617       -3     
  Lines         22803    22802       -1     
  Branches       3345     3369      +24     
============================================
- Hits          17677    17663      -14     
- Misses         3742     3760      +18     
+ Partials       1384     1379       -5     
Impacted Files Coverage Δ Complexity Δ
...va/mozilla/components/support/utils/Performance.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lla/components/support/migration/GeckoMigration.kt 71.42% <0.00%> (-3.58%) 3.00% <0.00%> (-1.00%)
...bar/provider/BookmarksStorageSuggestionProvider.kt
...re/awesomebar/provider/SearchSuggestionProvider.kt
...ozilla/components/lib/state/ext/StoreExtensions.kt
...rc/main/java/mozilla/components/lib/state/Store.kt
...va/mozilla/components/lib/state/helpers/Helpers.kt
...awesomebar/provider/ClipboardSuggestionProvider.kt
...main/java/mozilla/components/lib/state/ext/View.kt
...mponents/lib/state/internal/ReducerChainBuilder.kt
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d039f6...94a77af. Read the comment docs.

Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏲️

@csadilek csadilek self-assigned this Apr 29, 2020
@grigoryk
Copy link
Contributor Author

grigoryk commented May 1, 2020

bors r=csadilek

@bors
Copy link

bors bot commented May 1, 2020

Build succeeded:

@bors bors bot merged commit 37ac41f into mozilla-mobile:master May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

logElapsedTime should use SystemClock.elapsedRealtimeNanos instead of System.nanoTime()

2 participants