This repository was archived by the owner on Nov 1, 2022. It is now read-only.
Close #6903: Caught exception with no stack trace will be reported as UnexpectedlyMissingStacktrace #6946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6946 +/- ##
============================================
- Coverage 77.22% 77.09% -0.14%
- Complexity 4607 4870 +263
============================================
Files 628 652 +24
Lines 22807 23994 +1187
Branches 3312 3513 +201
============================================
+ Hits 17613 18497 +884
- Misses 3837 4038 +201
- Partials 1357 1459 +102
Continue to review full report at Codecov.
|
pocmo
reviewed
May 12, 2020
| */ | ||
| var reportThrowable = throwable | ||
| if (throwable.stackTrace.isEmpty()) { | ||
| reportThrowable = InvalidParameterException() |
There was a problem hiding this comment.
- If this is for debugging purposes: Maybe create a custom exception for this case?
- Let's also add the original throwable as
causeof the new exception, so that we get the original one too?
There was a problem hiding this comment.
Sure, I'll update. Thanks,
rocketsroger
force-pushed
the
AC_6903
branch
2 times, most recently
from
a8b8fe6 to
efab3b1
Compare
rocketsroger
changed the title
…be reported as UnexpectedlyMissingStacktrace
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge