Issue #7441: Remove unused ThumbnailsUseCase

[gabrielluong]

---

Fixes #7441

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry or does not need one
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

• Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
• Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

[codecov]

Codecov Report

Merging #7442 into master will increase coverage by 0.69%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7442      +/-   ##
============================================
+ Coverage     77.57%   78.26%   +0.69%     
+ Complexity     5147     4938     -209     
============================================
  Files           689      661      -28     
  Lines         25018    23150    -1868     
  Branches       3700     3446     -254     
============================================
- Hits          19408    18119    -1289     
+ Misses         4089     3603     -486     
+ Partials       1521     1428      -93     

Impacted Files	Coverage Δ	Complexity Δ
...la/components/feature/tabs/tabstray/TabsFeature.kt	95.00% <ø> (+4.09%)	7.00 <0.00> (ø)
...ponents/feature/tabs/tabstray/TabsTrayPresenter.kt	93.93% <ø> (-0.18%)	9.00 <0.00> (-1.00)
...feature/customtabs/store/CustomTabsServiceStore.kt	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-2.00%)
...ponents/browser/thumbnails/ThumbnailsMiddleware.kt	80.00% <0.00%> (-13.34%)	2.00% <0.00%> (-6.00%)
...onents/feature/customtabs/verify/OriginVerifier.kt	60.00% <0.00%> (-3.16%)	5.00% <0.00%> (ø%)
...la/components/browser/menu/BrowserMenuHighlight.kt	94.73% <0.00%> (-1.70%)	0.00% <0.00%> (ø%)
...feature/privatemode/feature/SecureWindowFeature.kt	88.88% <0.00%> (-1.12%)	3.00% <0.00%> (-1.00%)
...onents/feature/contextmenu/ContextMenuCandidate.kt	90.82% <0.00%> (-0.35%)	5.00% <0.00%> (ø%)
...ava/mozilla/components/ui/tabcounter/TabCounter.kt	79.83% <0.00%> (-0.33%)	13.00% <0.00%> (-1.00%)
...ts/service/digitalassetlinks/local/StatementApi.kt	92.45% <0.00%> (-0.28%)	13.00% <0.00%> (ø%)
... and 46 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87fe549...db4b0da. Read the comment docs.

[jonalmeida]

Thanks for the cleanup! I think there's a mistake on my part here: instead of removing the use case, in my PR that added the ThumbnailLoader, I should have used the use case instead. This would have gotten rid of that weird if-else check that we added into the Fenix TabsTrayViewHolder.

I like the idea of having use cases where it makes sense, but I'm open to alternatives too!

[gabrielluong]

Thanks for the cleanup! I think there's a mistake on my part here: instead of removing the use case, in my PR that added the ThumbnailLoader, I should have used the use case instead. This would have gotten rid of that weird if-else check that we added into the Fenix TabsTrayViewHolder.

I like the idea of having use cases where it makes sense, but I'm open to alternatives too!

Do you mean you want to wrap ThumbnailLoader into the ThumbnailUseCase constructor and have the use case functions call load?

[jonalmeida]

Let's go ahead and remove this, we can always bring it back if we decide otherwise.

@gabrielluong Don't forget to submit a Fenix PR for this breaking API when you land this.

[gabrielluong]

bors r=jonalmeida

[bors]

Timed out.

[bors]

Timed out.

[pocmo]

bors r+

[bors]

Build succeeded:

• complete-push