Issue #7138: Add ImageRequest to ImageLoader to allow consumers to sp…

[gabrielluong]

…ecify the preferred image size

---

Fixes #7138. This is very similar to BrowserIcons which uses an equivalent IconRequest.

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry or does not need one
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

• Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
• Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

[codecov]

Codecov Report

Merging #7448 into master will decrease coverage by 0.16%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master    #7448      +/-   ##
============================================
- Coverage     77.76%   77.59%   -0.17%     
- Complexity     5045     5133      +88     
============================================
  Files           647      690      +43     
  Lines         24170    24954     +784     
  Branches       3538     3682     +144     
============================================
+ Hits          18795    19364     +569     
- Misses         3903     4070     +167     
- Partials       1472     1520      +48     

Impacted Files	Coverage Δ	Complexity Δ
.../mozilla/components/support/images/ImageRequest.kt	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...la/components/support/images/loader/ImageLoader.kt	0.00% <ø> (ø)	0.00 <0.00> (ø)
...nts/browser/thumbnails/utils/ThumbnailDiskCache.kt	76.66% <50.00%> (ø)	8.00 <2.00> (ø)
...zilla/components/browser/tabstray/TabViewHolder.kt	93.75% <100.00%> (ø)	1.00 <0.00> (ø)
...ponents/browser/thumbnails/ThumbnailsMiddleware.kt	80.00% <100.00%> (ø)	2.00 <0.00> (ø)
...omponents/browser/thumbnails/ThumbnailsUseCases.kt	93.33% <100.00%> (ø)	1.00 <0.00> (ø)
...nents/browser/thumbnails/loader/ThumbnailLoader.kt	55.55% <100.00%> (ø)	5.00 <0.00> (ø)
...nts/browser/thumbnails/storage/ThumbnailStorage.kt	100.00% <100.00%> (ø)	6.00 <1.00> (ø)
...feature/customtabs/store/CustomTabsServiceStore.kt	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-2.00%)
...onents/feature/customtabs/verify/OriginVerifier.kt	60.00% <0.00%> (-3.16%)	5.00% <0.00%> (ø%)
... and 65 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40dbe4...74c1e91. Read the comment docs.

[jonalmeida]

This looks good!

It doesn't solve another problem we have: we store images to disk at their full res and not based on the desired quality (in this case 102dp).

That is to say, we're storing these large/high-res images to disk, but we only use them for a small thumbnail.

We can file a new issue for it: Add max size/res to images stored in ThumbnailStorage

[jonalmeida]

Don't forget to put up a PR for Fenix to address the breaking API changes.

[gabrielluong]

bors r=jonalmeida

[bors]

Build failed:

• complete-push

[gabrielluong]

bors retry

[bors]

Build failed:

• complete-push

[gabrielluong]

Last try seems to fail on a failed checkout of AC in the build for build-tooling-glean-gradle. Don't see anything wrong here with the given PR. Gonna retry.

[gabrielluong]

bors retry

[bors]

Build failed:

• complete-push

[gabrielluong]

bors retry

[bors]

Build succeeded:

• complete-push