Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Conversation

@csadilek
Copy link
Contributor

@csadilek csadilek commented Jul 3, 2020

This is replacing the deprecated runtime.registerWebExtension with the new webExtensionController.ensureBuiltIn for installing built-in extensions.

I've described the required steps here: #6356 (comment)

This is best reviewed by collapsing the tests. The actual changeset is pretty small and cleaned up the engine logic nicely (net negative lines of code). 🎉

@Amejia481 @psymoon Now that we've branched for release we can land this:

Marking as "Do not land" so I can coordinate landing with the required Fenix change.

@csadilek csadilek added 🕵️‍♀️ needs review PRs that need to be reviewed do not land PRs that requires coordination before landing labels Jul 3, 2020
@csadilek csadilek requested review from Amejia481 and psymoon July 3, 2020 19:41
@csadilek csadilek linked an issue Jul 3, 2020 that may be closed by this pull request
Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@psymoon psymoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@csadilek csadilek force-pushed the issue-6356 branch 2 times, most recently from bb2af66 to 6477bb7 Compare July 6, 2020 19:04
@csadilek
Copy link
Contributor Author

csadilek commented Jul 7, 2020

bors r=psymoon,Amejia481

@bors
Copy link

bors bot commented Jul 7, 2020

Build succeeded:

@bors bors bot merged commit f33ceb0 into mozilla-mobile:master Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

do not land PRs that requires coordination before landing 🕵️‍♀️ needs review PRs that need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install built-in extensions using GV extension controller

3 participants