Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Conversation

@NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Aug 6, 2020

In Gradle 6, buildSrc classes cannot be used inside settings.gradle. Inlining the Config class gets around this problem for us. The values inside the class have been moved to a YAML file so that it can be used by Taskcluster to check if data has changed, and used by the changelog to be a simple version overview.

We could also use a .properties file for this.

@NotWoods NotWoods added the 🏗️ build Build system, gradle, configuration label Aug 6, 2020
@psymoon psymoon requested a review from grigoryk August 10, 2020 17:40
@pocmo
Copy link
Contributor

pocmo commented Sep 9, 2020

bors try

bors bot pushed a commit that referenced this pull request Sep 9, 2020
@bors
Copy link

bors bot commented Sep 9, 2020

try

Timed out.

@pocmo
Copy link
Contributor

pocmo commented Sep 11, 2020

bors try

bors bot pushed a commit that referenced this pull request Sep 11, 2020
@bors
Copy link

bors bot commented Sep 11, 2020

try

Build succeeded:

Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link

bors bot commented Sep 11, 2020

Build succeeded:

@bors bors bot merged commit d974933 into mozilla-mobile:master Sep 11, 2020
@NotWoods NotWoods deleted the config branch September 11, 2020 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🏗️ build Build system, gradle, configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants