This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closes #1194: Adds search shortcut telemetry #1202
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned sblatz
Mar 26, 2019
ghost
added
the
review
label
Mar 26, 2019
sblatz
force-pushed
the
shortcut-telemetry
branch
from
March 26, 2019 21:53
08dfa46
to
58d1826
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
sblatz
changed the title
Closes #1194: Adds search shortcut telemetry
[WIP] Closes #1194: Adds search shortcut telemetry
Mar 26, 2019
sblatz
force-pushed
the
shortcut-telemetry
branch
from
March 27, 2019 15:10
58d1826
to
68a3fc8
Compare
sblatz
force-pushed
the
shortcut-telemetry
branch
from
March 27, 2019 16:17
68a3fc8
to
c117777
Compare
sblatz
changed the title
[WIP] Closes #1194: Adds search shortcut telemetry
Closes #1194: Adds search shortcut telemetry
Mar 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this almost the same PR, but with telemetry added?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to just this commit for review, as this is currently blocked on merging #882.