For #9136: Send all adjust properties to glean

[sblatz]

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

• Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[sblatz]

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?

• What marketing campaign was a user funneled in through?

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

• It will help us determine which marketing campaigns are effective.
• It will help us identify campaigns that increase retention

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?

• N/A (These are baseline metrics)

4. Can current instrumentation answer these questions?

• No, we have telemetry sent to Glean for these purposes in our installation ping, but we also need to send in our metrics ping as well for the data team to properly run analysis.

5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.

• All data is Category 2.

6. How long will this data be collected?

• Until 09/01/2020

7. What populations will you measure?

• All release, beta, and nightly users with telemetry enabled.

8. Please provide a general description of how you will analyze this data.

• Glean / Amplitude

9. Where do you intend to share the results of your analysis?

• Only on Glean, Amplitude and with mobile teams.

[codecov-io]

Codecov Report

Merging #9253 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #9253      +/-   ##
============================================
+ Coverage     19.51%   19.53%   +0.01%     
  Complexity      511      511              
============================================
  Files           329      329              
  Lines         13155    13158       +3     
  Branches       1747     1747              
============================================
+ Hits           2567     2570       +3     
  Misses        10364    10364              
  Partials        224      224              

Impacted Files	Coverage Δ	Complexity Δ
...la/fenix/components/metrics/GleanMetricsService.kt	8.63% <100.00%> (+0.82%)	3.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca05863...4f10d24. Read the comment docs.

[liuche]

Data review only

Data Review Form (to be filled by Data Stewards)

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, documented in metrics.yaml

2. Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, Fenix data controls

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Will expire 9/1

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2, adjust campaign fields based on campaign that user downloaded Fenix from.

5. Is the data collection request for default-on or default-off?

default on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

Yes, adding clientid to installation ping. This is the same information as the metrics ping, but sent when adjust fields resolve. Omitting the clientid was a bug, which didn't allow tracking retention.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes, this includes the clientid but the ping is the same as the metrics ping.

8. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

Will be reviewed 9/1/2020

9. Does the data collection use a third-party collection tool? If yes, escalate to legal.
   No