Skip to content
This repository was archived by the owner on Oct 18, 2018. It is now read-only.

Conversation

@ncalexan
Copy link
Contributor

@ncalexan ncalexan commented Mar 4, 2014

No description provided.

@ncalexan
Copy link
Contributor Author

ncalexan commented Apr 3, 2014

@rnewman I folded in your earlier review comments, and reworked the requestSync function to declare hints:

  • Android scheduling;
  • local rate limiting;
  • remote server backoffs.

These patches declare the hints, but the corresponding FxAccountSyncAdapter code to act on them will be a separate ticket. I'm hoping this is enough for now. Note: I have not device tested these patches yet, but will (of course) do so soon.

@rnewman
Copy link
Contributor

rnewman commented Apr 3, 2014

Other than having two Part 3s, this looks perfect.

@rnewman
Copy link
Contributor

rnewman commented Apr 3, 2014

As such, it's like traditional Jewish art.

@rnewman
Copy link
Contributor

rnewman commented Apr 4, 2014

Ship it ship it

@ncalexan
Copy link
Contributor Author

ncalexan commented Apr 7, 2014

Landed.

@ncalexan ncalexan closed this Apr 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants