Skip to content

Conversation

@diox
Copy link
Member

@diox diox commented Nov 24, 2025

Fixes mozilla/addons#15758

We are enabling/disabling locales depending on whether their completion percentage so a permanent (301) redirect could be problematic.

The caching duration could still be an issue, but at least the non-permanent nature of the redirect should make things easier, and it's more consistent with addons-server which was already using a 302 (with that same caching duration).

We are enabling/disabling locales depending on whether their
completion percentage so a permanent (301) redirect could be
problematic.

The caching duration could still be an issue, but at least
the non-permanent nature of the redirect should make things
easier, and it's more consistent with addons-server which was
already using a 302 (with that same caching duration).
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.15%. Comparing base (3854bdb) to head (caacbd8).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13929   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files         265      265           
  Lines       10661    10664    +3     
  Branches     3274     3275    +1     
=======================================
+ Hits        10464    10467    +3     
  Misses        184      184           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@diox diox requested review from a team and eviljeff and removed request for a team November 24, 2025 15:39
Copy link
Member

@eviljeff eviljeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of weird when you go to http://127.0.0.1:3333/en-GC/ you get redirected to http://127.0.0.1:3333/en-GB/firefox/en-GC/ rather than http://127.0.0.1:3333/en-GB/firefox/ but that's existing behaviour.

That redirect is still a 301 though - should it also be a 302?

@diox
Copy link
Member Author

diox commented Nov 24, 2025

Yeah I wasn't sure if we wanted to also change that one... I guess we do.

@diox diox requested a review from eviljeff November 25, 2025 13:25
@diox diox merged commit 6990e5e into mozilla:master Nov 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: use a 302 - temporary redirect - for locale redirects for frontend

2 participants