Quantum compat is true for all webext / moz addons #3896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar303
commented
Nov 13, 2017
| const addon = createInternalAddon(createFakeAddon({ | ||
| files: [{ | ||
| is_webextension: true, | ||
| platform: OS_ANDROID, |
Contributor
Author
There was a problem hiding this comment.
When I added this, the old code was failing because of the desktop UA string. Oops.
willdurand
reviewed
Nov 13, 2017
| export const isQuantumCompatible = ({ addon }) => { | ||
| // HACK: we use a hardcoded User Agent string corresponding to MacOS/Firefox | ||
| // 57.0 to determine whether the given `addon` is compatible with Quantum. | ||
| // The OS is not important as far as it is not `iOS`. |
Member
There was a problem hiding this comment.
haha, who wrote this comment? 😓
| const addon = createInternalAddon(createFakeAddon({ | ||
| files: [{ | ||
| is_webextension: true, | ||
| platform: OS_ANDROID, |
src/core/utils/compatibility.js
Outdated
| // These checks are fragile because future mozilla-signed extensions | ||
| // may not be Quantum compatible. | ||
| return file.is_webextension || file.is_mozilla_signed_extension; | ||
| }); |
Member
There was a problem hiding this comment.
The isWebExtension computed prop was already available. How do you feel about computing isMozillaSignedExtension in the reducer then?
Codecov Report
@@ Coverage Diff @@
## master mozilla/addons-frontend#3896 +/- ##
==========================================
- Coverage 96.27% 96.27% -0.01%
==========================================
Files 184 184
Lines 3838 3837 -1
Branches 782 782
==========================================
- Hits 3695 3694 -1
Misses 123 123
Partials 20 20
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#11173
I tested with some dev data. The following should all show up as compatible with Quantum:
This should show up as incompatible with Quantum: