Add simplistic user-agent lookup #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core/utils.js
Outdated
| // whereas the previous behaviour was to only return 'android' for FF Android. | ||
| // This way we are showing more relevant content, and if we prompt for the user to download | ||
| // firefox we can prompt them to download Firefox for Android. | ||
| if (userAgentString.includes('Android')) { |
There was a problem hiding this comment.
should this be case insensitive? Or do we not worry about that?
There was a problem hiding this comment.
All the strings I found seem to have 'Android' title-case but it won't hurt to make it check lower-case .
|
r+wc |
muffinresearch
force-pushed
the
add-user-agent-app-lookup
branch
from
cceafe8 to
ca8d061
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9783