Add stubbed out details page components #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/amo/components/AddonDetail.js
Outdated
| </header> | ||
|
|
||
| <section className="addon-metadata"> | ||
| <h2 className="visually-hidden">Extension Metadata</h2> |
There was a problem hiding this comment.
this title will one day be localized, right? I think it would be good to wrap it in gettext because otherwise strings like this are hard to track down.
|
Great start! r+wc |
muffinresearch
force-pushed
the
add-detail-page-stub
branch
from
7ca647c to
f592b59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a bunch of stub components to represent the AddonDetails page to get us off the blocks.
It's all implicitly tested at the moment, but as the components are fleshed out we'll add the necessary tests.
Nothing is set in stone either so expect a lot of this to change as we iterate.
If you want to see it - check this branch out, run
npm run dev:amoand go to/en-US/firefox/addon/anything/