Add tox support for running UI tests #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davehunt I wonder if it would make much difference if the tox setup only ran when tox is being run as opposed to tox etc being installed for each test in the matrix? |
|
r+wc |
|
@davehunt is this ready to land? I added one additional comment above but otherwise it looks good to me. |
|
@muffinresearch I agree with your comment but haven't had time to address it - I'm in a work week, so might not have much time to focus on this until next week. If you're happy to merge and then address your comments in a separate patch, that works for me too. |
|
@davehunt yep, may as well ship it and I'll file an issue for optimising the deps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #887