Skip to content

Conversation

@bhearsum
Copy link
Contributor

This is part 1 of 3 to give us a smooth upgrade path for #346. This part backs out most of the original patch. The parts that remain are the addition of the memory and instructionSet columns (we're doing a plain add there, instead of a renaming of systemCapabilities), and the changes to the rules tests -- because the new columns show up in the responses. With this patch, the old and new columns will all be in the db, but only systemCapabilities will be used when fulfilling update requests.

I verified this series of patches by starting off on 741a56c locally, and then applying each patch in the series - verifying that the correct updates were served for each, that the admin interface worked, and that tests passed. I intend to have stage's database downgraded before merging this (much easier to do that than to try to cope with the migrations from #346 being in one database but not the other IMO).

@bhearsum bhearsum self-assigned this Jul 10, 2017
@bhearsum bhearsum requested a review from nthomas-mozilla July 10, 2017 19:31
This was referenced Jul 10, 2017
Copy link
Contributor

@nthomas-mozilla nthomas-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I reviewed based on the net effect of the initial landing and this backout (specifically f8d9bd8...mozbhearsum:2e4ebda457b98aeb7aff406a1ea3aed3a5e6598a).

@bhearsum bhearsum merged commit bbe7976 into mozilla-releng:master Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants