Automate /locales/ page based on settings (fixes #6454)
#11546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmac
reviewed
Apr 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #11546 +/- ##
==========================================
- Coverage 77.08% 77.07% -0.01%
==========================================
Files 144 144
Lines 7553 7559 +6
==========================================
+ Hits 5822 5826 +4
- Misses 1731 1733 +2
Continue to review full report at Codecov.
|
robhudson
force-pushed
the
6454-automate-locales-page
branch
from
31978a4 to
e8578bc
Compare
|
Updated pulling the native locale strings from |
pmac
reviewed
Apr 27, 2022
| @@ -128,6 +128,92 @@ def data_path(*args): | |||
| # path to updated p-d data for testing before loading into DB | |||
| PROD_DETAILS_TEST_DIR = str(Path(PROD_DETAILS_JSON_REPO_PATH).joinpath("public", "1.0")) | |||
|
|
|||
| # Regions defined on the `/locales/` page. | |||
| LOCALES_BY_REGION = { | |||
robhudson
force-pushed
the
6454-automate-locales-page
branch
2 times, most recently
from
83f9d65 to
9c5b826
Compare
robhudson
force-pushed
the
6454-automate-locales-page
branch
from
9c5b826 to
6e25ca9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Changing
/locales/from hard-coded to using our settings to generate it.Issue / Bugzilla link
#6454