Skip to content

wip - verify autograph-stage mar signatures#49

Merged
catlee merged 2 commits into
mozilla-releng:masterfrom
escapewindow:autograph-stage
Feb 12, 2019
Merged

wip - verify autograph-stage mar signatures#49
catlee merged 2 commits into
mozilla-releng:masterfrom
escapewindow:autograph-stage

Conversation

@escapewindow
Copy link
Copy Markdown
Contributor

Assuming this approach is ok, I plan to:

  • add the autograph-stage mar pubkey in-tree
  • add the autograph-stage mar pubkey in mardor, to allow for signature verification (this PR)
  • add the autograph-stage creds to the dep signing passwords file
  • add the capability to verify mar signatures, via mardor, in signingscript. This could be optional or on by default.
  • add a nightly task [that doesn't run by default] that signs a mar through depsigning scriptworkers->autograph-stage, and verifies it through mardor, and turns green if successful
    • the plan is for anyone with the right scopes to be able to add task this task against the most recent nightly graph, and check its status.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 8, 2019

Codecov Report

Merging #49 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   98.57%   98.57%   +<.01%     
==========================================
  Files           8        8              
  Lines         701      702       +1     
  Branches      125      125              
==========================================
+ Hits          691      692       +1     
  Misses          2        2              
  Partials        8        8
Impacted Files Coverage Δ
src/mardor/cli.py 98.34% <ø> (ø) ⬆️
src/mardor/mozilla.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce36be...61fdc08. Read the comment docs.

Comment thread get_mozilla_keys.sh Outdated
get_key "dep2.der" "dep2_sha1" $SHA1_REV
echo

get_key "autograph_stage.der" "autograph_stage_sha384" $SHA384_REV
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change this to autograph_stage.pem, and possibly write a new get_pem_key helper function to not expect a der format file.

@catlee catlee merged commit 204a753 into mozilla-releng:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants