frontend: fix camelcase rule

Author: Bastien Abadie

frontend/src/common.js

@@ -18,14 +18,14 @@ export async function main(load, display) {
   // Wait for DOM to be ready before displaying
   await DOM_READY;
   await display(data);
-  monitor_options();
+  monitorOptions();
 
   // Full workflow, loading then displaying data
   // used for following updates
   const full = async function() {
     const data = await load();
     await display(data);
-    monitor_options();
+    monitorOptions();
   };
 
   // React to url changes
@@ -36,13 +36,13 @@ export async function main(load, display) {
 
 const COVERAGE_BACKEND_HOST = process.env.BACKEND_URL;
 
-function cache_get(cache, key) {
+function cacheGet(cache, key) {
   if (key in cache) {
     return cache[key].val;
   }
 }
 
-function cache_set(cache, key, value) {
+function cacheSet(cache, key, value) {
   const now = new Date().getTime() / 1000;
 
   // If the cache got too big, remove all elements that were added more
@@ -61,10 +61,10 @@ function cache_set(cache, key, value) {
   };
 }
 
-const path_coverage_cache = {};
-export async function get_path_coverage(path, changeset, platform, suite) {
-  const cache_key = `${changeset}_${path}_${platform}_${suite}`;
-  let data = cache_get(path_coverage_cache, cache_key);
+const pathCoverageCache = {};
+export async function getPathCoverage(path, changeset, platform, suite) {
+  const cacheKey = `${changeset}_${path}_${platform}_${suite}`;
+  let data = cacheGet(pathCoverageCache, cacheKey);
   if (data) {
     return data;
   }
@@ -87,20 +87,20 @@ export async function get_path_coverage(path, changeset, platform, suite) {
   }
   data = await response.json();
 
-  cache_set(path_coverage_cache, cache_key, data);
+  cacheSet(pathCoverageCache, cacheKey, data);
 
   return data;
 }
 
-const history_cache = {};
-export async function get_history(path, platform, suite) {
+const historyCache = {};
+export async function getHistory(path, platform, suite) {
   // Backend needs path without trailing /
   if (path && path.endsWith("/")) {
     path = path.substring(0, path.length - 1);
   }
 
-  const cache_key = `${path}_${platform}_${suite}`;
-  let data = cache_get(history_cache, cache_key);
+  const cacheKey = `${path}_${platform}_${suite}`;
+  let data = cacheGet(historyCache, cacheKey);
   if (data) {
     return data;
   }
@@ -115,7 +115,7 @@ export async function get_history(path, platform, suite) {
   const response = await fetch(`${COVERAGE_BACKEND_HOST}/v2/history?${params}`);
   data = await response.json();
 
-  cache_set(history_cache, cache_key, data);
+  cacheSet(historyCache, cacheKey, data);
 
   // Check data has coverage values
   // These values are missing when going above 2 levels right now
@@ -130,41 +130,41 @@ export async function get_history(path, platform, suite) {
   return data;
 }
 
-const zero_coverage_cache = {};
-export async function get_zero_coverage_data() {
-  let data = cache_get(zero_coverage_cache, "");
+const zeroCoverageCache = {};
+export async function getZeroCoverageData() {
+  let data = cacheGet(zeroCoverageCache, "");
   if (data) {
     return data;
   }
 
   const response = await fetch(
-    "https://index.taskcluster.net/v1/task/project.releng.services.project.production.code_coverage_bot.latest/artifacts/public/zero_coverage_report.json"
+    "https://index.taskcluster.net/v1/task/project.releng.services.project.production.code_coverage_bot.latest/artifacts/public/zeroCoverage_report.json"
   );
   data = await response.json();
 
-  cache_set(zero_coverage_cache, "", data);
+  cacheSet(zeroCoverageCache, "", data);
 
   return data;
 }
 
-const filters_cache = {};
-export async function get_filters() {
-  let data = cache_get(filters_cache, "");
+const filtersCache = {};
+export async function getFilters() {
+  let data = cacheGet(filtersCache, "");
   if (data) {
     return data;
   }
 
   const response = await fetch(`${COVERAGE_BACKEND_HOST}/v2/filters`);
   data = await response.json();
 
-  cache_set(filters_cache, "", data);
+  cacheSet(filtersCache, "", data);
 
   return data;
 }
 
 // Option handling.
 
-export function is_enabled(opt) {
+export function isEnabled(opt) {
   const route = readRoute();
   let value = "off";
   if (route[opt]) {
@@ -175,7 +175,7 @@ export function is_enabled(opt) {
   return value === "on";
 }
 
-function monitor_options() {
+function monitorOptions() {
   // Monitor input & select changes
   const fields = document.querySelectorAll("input, select");
   for (const field of fields) {
@@ -205,7 +205,7 @@ function monitor_options() {
 
 // hgmo.
 
-export async function get_source(file) {
+export async function getSource(file) {
   const response = await fetch(
     `https://hg.mozilla.org/mozilla-central/raw-file/tip/${file}`
   );
@@ -214,24 +214,24 @@ export async function get_source(file) {
 
 // Filtering.
 
-const get_third_party_paths = (function() {
+const getThirdPartyPaths = (function() {
   let paths = null;
   return async function() {
     if (!paths) {
-      const response = await get_source("tools/rewriting/ThirdPartyPaths.txt");
+      const response = await getSource("tools/rewriting/ThirdPartyPaths.txt");
       paths = response.split("\n").filter(path => path !== "");
     }
 
     return paths;
   };
 })();
 
-export async function filter_third_party(files) {
-  if (is_enabled("third_party")) {
+export async function filterThirdParty(files) {
+  if (isEnabled("third_party")) {
     return files;
   }
 
-  const paths = await get_third_party_paths();
+  const paths = await getThirdPartyPaths();
 
   return files.filter(file => {
     for (const path of paths) {
@@ -244,9 +244,9 @@ export async function filter_third_party(files) {
   });
 }
 
-export function filter_languages(files) {
-  const cpp = is_enabled("cpp");
-  const cpp_extensions = [
+export function filterLanguages(files) {
+  const cpp = isEnabled("cpp");
+  const cppExtensions = [
     "c",
     "cpp",
     "cxx",
@@ -258,68 +258,68 @@ export function filter_languages(files) {
     "inl",
     "inc"
   ];
-  const js = is_enabled("js");
-  const js_extensions = ["js", "jsm", "xml", "xul", "xhtml", "html"];
-  const java = is_enabled("java");
-  const java_extensions = ["java"];
-  const rust = is_enabled("rust");
-  const rust_extensions = ["rs"];
+  const js = isEnabled("js");
+  const jsExtensions = ["js", "jsm", "xml", "xul", "xhtml", "html"];
+  const java = isEnabled("java");
+  const javaExtensions = ["java"];
+  const rust = isEnabled("rust");
+  const rustExtensions = ["rs"];
 
   return files.filter(file => {
     if (file.type === "directory") {
       return true;
-    } else if (cpp_extensions.find(ext => file.path.endsWith("." + ext))) {
+    } else if (cppExtensions.find(ext => file.path.endsWith("." + ext))) {
       return cpp;
-    } else if (js_extensions.find(ext => file.path.endsWith("." + ext))) {
+    } else if (jsExtensions.find(ext => file.path.endsWith("." + ext))) {
       return js;
-    } else if (rust_extensions.find(ext => file.path.endsWith("." + ext))) {
+    } else if (rustExtensions.find(ext => file.path.endsWith("." + ext))) {
       return rust;
-    } else if (java_extensions.find(ext => file.path.endsWith("." + ext))) {
+    } else if (javaExtensions.find(ext => file.path.endsWith("." + ext))) {
       return java;
     }
     console.warn("Unknown language for " + file.path);
     return false;
   });
 }
 
-export function filter_headers(files) {
-  if (is_enabled("headers")) {
+export function filterHeaders(files) {
+  if (isEnabled("headers")) {
     return files;
   }
 
   return files.filter(file => !file.path.endsWith(".h"));
 }
 
-export function filter_completely_uncovered(files) {
-  if (!is_enabled("completely_uncovered")) {
+export function filterCompletelyUncovered(files) {
+  if (!isEnabled("completely_uncovered")) {
     return files;
   }
 
   return files.filter(file => file.uncovered);
 }
 
-export function filter_last_push_date(files) {
+export function filterLastPushDate(files) {
   const elem = document.getElementById("last_push");
-  const upper_limit = new Date();
-  let lower_limit = new Date();
+  const upperLimit = new Date();
+  let lowerLimit = new Date();
 
   if (elem.value === "one_year") {
-    lower_limit.setFullYear(upper_limit.getFullYear() - 1);
+    lowerLimit.setFullYear(upperLimit.getFullYear() - 1);
   } else if (elem.value === "two_years") {
-    upper_limit.setFullYear(upper_limit.getFullYear() - 1);
-    lower_limit.setFullYear(lower_limit.getFullYear() - 2);
+    upperLimit.setFullYear(upperLimit.getFullYear() - 1);
+    lowerLimit.setFullYear(lowerLimit.getFullYear() - 2);
   } else if (elem.value === "older_than_two_years") {
-    upper_limit.setFullYear(upper_limit.getFullYear() - 2);
-    lower_limit = new Date("1970-01-01T00:00:00Z");
+    upperLimit.setFullYear(upperLimit.getFullYear() - 2);
+    lowerLimit = new Date("1970-01-01T00:00:00Z");
   } else {
     return files;
   }
 
   return files.filter(file => {
-    const last_push_date = new Date(file.last_push_date);
+    const lastPushDate = new Date(file.lastPushDate);
     if (
-      last_push_date.getTime() <= upper_limit.getTime() &&
-      last_push_date.getTime() >= lower_limit.getTime()
+      lastPushDate.getTime() <= upperLimit.getTime() &&
+      lastPushDate.getTime() >= lowerLimit.getTime()
     ) {
       return true;
     }
@@ -328,7 +328,7 @@ export function filter_last_push_date(files) {
 }
 
 // Build the urls for a breadcrumb Navbar from a path
-export function build_navbar(path, revision) {
+export function buildNavbar(path, revision) {
   if (path.endsWith("/")) {
     path = path.substring(0, path.length - 1);
   }