frontend: Do not extract comments in separate files on release. #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The nice thing about having a separate file with LICENSE info is that we don't load it at runtime (even though right now the file is pretty small). |
Contributor
Author
|
I filed an issue on task-boot to do that mozilla/task-boot#61 But i think this is not really interesting for the frontend for now, as it only avoid loading the mustache header |
Collaborator
|
Yeah right now it's not so useful, but if we add more files with license comments it might be a win. |
marco-c
approved these changes
Sep 9, 2019
Collaborator
marco-c
left a comment
marco-c
left a comment
There was a problem hiding this comment.
Fine by me if you want to merge this as-is and file an issue to revert it after the task-boot issue is fixed, or if you want to fix the issue in task-boot and just close this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid building an extra file with just comments that crashes the deployment task (no content type detected)