Adding in documentation for newly added user states fields, in additi… #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to newly added updates to `clients_last_seen`.
irrationalagent
approved these changes
Dec 10, 2020
felixlawrence
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
This documentation LGTM. I'm not reviewing the definitions themselves because I believe you're already aware of my suggested potential improvements, the definitions are already settled, and as is they're good enough to be useful
I like how you dodge the "how should we define MAU" discussion by describing "two basic ways to calculate a time series" and not giving that time series a name! Well played 😛
added 3 commits
December 11, 2020 09:21
…k to user segments section, and additional description to `days_since_created_profile`.
…k to user segments section, and additional description to `days_since_created_profile`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in documentation for newly added activity segments. In addition, updating documentation for
clients_last_seento provide field descriptions for several high-value fields.