Skip to content

chore(nimbus): add statsd metrics for user interaction counts and review timing #13412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

chore(nimbus): add statsd metrics for user interaction counts and review timing #13412

merged 1 commit into from
Sep 11, 2025

Conversation

@relud
Copy link
Contributor

@relud relud commented Sep 2, 2025

Because

  • We want more visibility into experimenter activity

This commit

  • Adds a count metric for every nimbus ui interaction that generates a changelog
  • Adds a timing metric for how long it takes experiments to be reviewed

Fixes #13409

@relud relud force-pushed the relud-nimbus-ui-metrics branch from 8b9d92b to 047db91 Compare September 2, 2025 17:39
relud
relud commented Sep 2, 2025
View reviewed changes
@relud relud force-pushed the relud-nimbus-ui-metrics branch from 047db91 to bc8c495 Compare September 2, 2025 19:55
yashikakhurana
yashikakhurana approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and simple perfect change, thank you @relud 🎉

experimenter/experimenter/nimbus_ui/forms.py Outdated
Comment on lines 1225 to 1237
if (
previous_publish_status == NimbusExperiment.PublishStatus.REVIEW
and self.publish_status != NimbusExperiment.PublishStatus.REVIEW
):
delta = datetime.now(UTC) - self.changes.latest_review_request().changed_on
delta_ms = int(delta.total_seconds() * 1000)
metrics.timing(
"review_timing", value=delta_ms, tags=[f"status:{self.publish_status}"]
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 perfect

@relud relud force-pushed the relud-nimbus-ui-metrics branch from be9bee1 to 11f80bf Compare September 10, 2025 22:40
@relud relud enabled auto-merge September 10, 2025 22:42
@relud relud force-pushed the relud-nimbus-ui-metrics branch from 0069454 to c74f9a4 Compare September 11, 2025 17:37
@relud relud disabled auto-merge September 11, 2025 17:39
@relud relud force-pushed the relud-nimbus-ui-metrics branch from c74f9a4 to 8f21ec2 Compare September 11, 2025 17:42
@relud relud enabled auto-merge September 11, 2025 17:43
@relud relud disabled auto-merge September 11, 2025 17:53
@relud relud force-pushed the relud-nimbus-ui-metrics branch from 8f21ec2 to 895f16f Compare September 11, 2025 17:55
@relud relud force-pushed the relud-nimbus-ui-metrics branch from 895f16f to 0907df1 Compare September 11, 2025 19:58
@relud relud enabled auto-merge September 11, 2025 19:58
@relud relud added this pull request to the merge queue Sep 11, 2025
Merged via the queue into main with commit ccd994d Sep 11, 2025
17 checks passed
@relud relud deleted the relud-nimbus-ui-metrics branch September 11, 2025 20:44
b4handjr pushed a commit that referenced this pull request Sep 29, 2025
@relud @b4handjr
chore(nimbus): add statsd metrics for user interaction counts and rev…
02a535b 
…iew timing (#13412)

Because

- We want more visibility into experimenter activity

This commit

- Adds a count metric for every nimbus ui interaction that generates a
changelog
- Adds a timing metric for how long it takes experiments to be reviewed

Fixes #13409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yashikakhurana yashikakhurana yashikakhurana approved these changes

@jaredlockhart jaredlockhart Awaiting requested review from jaredlockhart jaredlockhart is a code owner

@freshstrangemusic freshstrangemusic Awaiting requested review from freshstrangemusic freshstrangemusic is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

create experimenter user interaction metrics

3 participants

@relud @yashikakhurana