Skip to content

feat(nimbus): add mobile 3dr ingestion into experimenter #15480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moibra05 merged 1 commit into from
Apr 29, 2026
Merged

feat(nimbus): add mobile 3dr ingestion into experimenter #15480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion experimenter/experimenter/experiments/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,7 +915,8 @@ class FirefoxLabsGroups(models.TextChoices):
DAILY_ACTIVE_USERS = "client_level_daily_active_users_v2"
DAYS_OF_USE = "days_of_use"
RETENTION = "retained"
RETENTION_3_DAYS = "active_in_last_3_days_legacy"
RETENTION_3_DAYS = "active_in_last_3_days"
RETENTION_3_DAYS_DESKTOP = "active_in_last_3_days_legacy"
SEARCH_COUNT = "search_count"

DAU_METRIC = {
Expand Down
16 changes: 7 additions & 9 deletions experimenter/experimenter/jetstream/results_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,16 +316,14 @@ def check_valid_point(point):
def get_kpi_metrics(
self, analysis_basis, segment, reference_branch, window="overall"
):
kpi_metrics = [m.copy() for m in NimbusConstants.KPI_METRICS]

kpi_metrics = NimbusConstants.KPI_METRICS.copy()

# 3-day retention is only available for Desktop experiments
if self.experiment.application != self.experiment.Application.DESKTOP:
kpi_metrics = [
m
for m in kpi_metrics
if m.get("slug") != NimbusConstants.RETENTION_3_DAYS
]
# For desktop experiments, use legacy version of metric until Glean migration
if self.experiment.application == self.experiment.Application.DESKTOP:
for m in kpi_metrics:
if m.get("slug") == NimbusConstants.RETENTION_3_DAYS:
m["slug"] = NimbusConstants.RETENTION_3_DAYS_DESKTOP
break

window_results = self.get_window_results(analysis_basis, segment, window)
other_metrics = (
Expand Down
58 changes: 39 additions & 19 deletions experimenter/experimenter/jetstream/tests/test_results_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2642,33 +2642,53 @@ def test_metrics_have_data_different_windows(self, results_data, expected):
expected,
)

def test_get_kpi_metrics_excludes_3day_retention_for_non_desktop(self):
fenix_outcome = Outcomes.get_by_slug_and_application(
"fenix_outcome", NimbusExperiment.Application.FENIX
)
fenix_experiment = NimbusExperimentFactory.create(
application=NimbusExperiment.Application.FENIX,
primary_outcomes=[fenix_outcome.slug],
secondary_outcomes=[],
@parameterized.expand(
[
(
NimbusExperiment.Application.DESKTOP,
[
"client_level_daily_active_users_v2",
"retained",
"search_count",
"active_in_last_3_days_legacy",
],
),
(
NimbusExperiment.Application.FENIX,
[
"client_level_daily_active_users_v2",
"retained",
"search_count",
"active_in_last_3_days",
],
),
(
NimbusExperiment.Application.IOS,
[
"client_level_daily_active_users_v2",
"retained",
"search_count",
"active_in_last_3_days",
],
),
]
)
def test_get_kpi_metrics_by_application(self, application, expected_metric_slugs):
experiment = NimbusExperimentFactory.create(
application=application,
)
NimbusBranchFactory.create(
experiment=fenix_experiment, name="Branch A", slug="branch-a"
experiment=experiment, name="Branch A", slug="branch-a"
)
NimbusBranchFactory.create(
experiment=fenix_experiment, name="Branch B", slug="branch-b"
experiment=experiment, name="Branch B", slug="branch-b"
)

fenix_results_manager = ExperimentResultsManager(fenix_experiment)
kpi_metrics = fenix_results_manager.get_kpi_metrics(
"enrollments", "all", "branch-a"
)
results_manager = ExperimentResultsManager(experiment)
kpi_metrics = results_manager.get_kpi_metrics("enrollments", "all", "branch-a")

slugs = [metric["slug"] for metric in kpi_metrics]
self.assertNotIn("active_in_last_3_days_legacy", slugs)

# Verify base KPI metrics are still present
self.assertIn("retained", slugs)
self.assertIn("search_count", slugs)
self.assertEqual(set(slugs), set(expected_metric_slugs))

@parameterized.expand(
[
Expand Down
Loading