Fixes 1225224 - Prompt on clearing History when signed in to Sync#1369
Merged
Fixes 1225224 - Prompt on clearing History when signed in to Sync#1369
Conversation
Contributor
There was a problem hiding this comment.
I'd call this clearSyncedHistory; it won't propagate to the server yet.
Contributor
|
Looks good with those changes, current strings from d5b0d46, and a follow-up for more precise conditional. |
st3fan
force-pushed
the
st3fan/Bug1225224PromptOnClearSyncedHistory
branch
from
011f2ff to
6179f64
Compare
st3fan
force-pushed
the
st3fan/Bug1225224PromptOnClearSyncedHistory
branch
from
59134c5 to
4436204
Compare
st3fan
added a commit
that referenced
this pull request
Dec 17, 2015
…yncedHistory Fixes 1225224 - Prompt on clearing History when signed in to Sync
Contributor
|
Follow-up is #1370. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch shows a confirmation dialog when you Clear Private Data with History selected when logged in to Sync. It will show the following: