Bug 1240057 - Only reload the pre-redirect URL if we've changed UAs#1462
Merged
thebnich merged 1 commit intomozilla-mobile:masterfrom Jan 21, 2016
Merged
Bug 1240057 - Only reload the pre-redirect URL if we've changed UAs#1462thebnich merged 1 commit intomozilla-mobile:masterfrom
thebnich merged 1 commit intomozilla-mobile:masterfrom
Conversation
thebnich
force-pushed
the
refresh-origin
branch
from
7d5cffb to
5e2de27
Compare
thebnich
added a commit
that referenced
this pull request
Jan 21, 2016
Bug 1240057 - Only reload the pre-redirect URL if we've changed UAs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, we're using
loadRequestinstead ofreloadevery time we refresh the page after a redirect. This logic is here so that enabling/disabling Request Desktop Site tries the original URL instead of the redirected URL, but that's the only time we need to do it. This adds a check to follow this path only if the UA has changed.I also changed
ReloadIgnoringLocalAndRemoteCacheDatatoReloadIgnoringLocalCacheDatabecause the docs forReloadIgnoringLocalAndRemoteCacheDatasay, "This constant is unimplemented and shouldn’t be used" (thanks, Apple).