Bug 1271380 - Report search counts in core ping#1843
Merged
thebnich merged 2 commits intomozilla-mobile:masterfrom May 26, 2016
Merged
Bug 1271380 - Report search counts in core ping#1843thebnich merged 2 commits intomozilla-mobile:masterfrom
thebnich merged 2 commits intomozilla-mobile:masterfrom
Conversation
fba4515 to
8877c0e
Compare
There was a problem hiding this comment.
I'd explain why you don't try to send when you don't have connectivity – i.e. because it resets your measurements & increments seq, e.g. like your comment on this PR.
ccd1cd8 to
7be34c1
Compare
Contributor
|
I think this is a great start. We can do buffering of pings later. |
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
…d String methods (mozilla-mobile#1843)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit creates/send the core ping only if we have an active network connection. The second commit adds search recording to our
SearchViewControllerand reports this data with the core ping.When creating the core ping, we immediately reset the search data that we're reporting. That means if we create the ping but the ping isn't successful, we'll drop the data. That's why the network connectivity check was added to the PR: it increases the likelihood that the ping will succeed.
Unless we want to take the time to implement a telemetry fault-handling layer that stores and resends unique pings, I think this is the best we can do. The other option would be to reset the count only after receiving an HTTP 200, where we'd instead be sending potentially duplicate pings instead of dropping them. I agree with mcomella's comment that missing data is better than bad data.