Merged
Conversation
st3fan
added a commit
that referenced
this pull request
Jun 29, 2015
…tion Fixes 1175897 - Send Tab not localized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR The Send Tab action title is now correctly localized when presented in the system-provided Share sheet.
This patch fixes a couple of things:
.stringsfile. They would end up in the project asXX.lproj/Info.plist, which is wrong. They are now written toXX.lproj/InfoPlist.stringsso that the strings are correctly picked up by iOS.xliff-cleanup.pyscript was broken and I think it never correctly processedInfo.plistsections anyway.CFBundleDisplayNamebut we now make an exception if that key is found inExtensions/SendTo/Info.plistThis patch also makes sure the
NSLocationWhenInUseUsageDescriptionkey is output toClient/XX.lproj/InfoPlist.strings. I don't think it correctly worked before.