Bug 1173789 - Showing Network activity spinner

[kar1m]

No description provided.

[st3fan]

This is too simple.

For example, when the WKWebView fails to load and finishes via didFailNavigation:, the network spinner is never stopped.

Also, when a page loads and is put in the background because you open a new tab, the navigation delegate for the BrowserViewController is switched around so you will never receive a didFinish or didFail. So it may be better to do this in the TabManager which is a WKNavigationDelegate for all open tabs.

I think we should use an atomic counter to keep track of the state of all open tabs combined. So that multiple tabs can increment and decrement the spinner state counter and then networkActivityIndicatorVisible can be configured based on that.

Just keep in mind that there are many tabs loading at the same time.

[st3fan]

@kar1m I don't have a good feeling about this because there is so much state that we need to track. I am wondering if we can do this in a different way.

For example, the WKWebView has a loading property. What do you think of using that? We could use KVO to receive loading state changes and based on that show/hide the spinner. Then there is just one thing we need to look at.

You could use loading as a trigger. If it changes to true then you know you need to start the spinner. If it changes to false then you could loop over all WKWebView instances that we have and quickly see if any one of them is still loading or not. And do the same check after a tab is closed.