Bug 1167970 - Bluetooth Keyboard Shortcuts For Common Actions: New tab#780
Closed
kar1m wants to merge 1 commit intomozilla-mobile:masterfrom
kar1m:karim/Bug1167970-KeyboardShortcutsForCommonActions
Closed
Bug 1167970 - Bluetooth Keyboard Shortcuts For Common Actions: New tab#780kar1m wants to merge 1 commit intomozilla-mobile:masterfrom kar1m:karim/Bug1167970-KeyboardShortcutsForCommonActions
kar1m wants to merge 1 commit intomozilla-mobile:masterfrom
kar1m:karim/Bug1167970-KeyboardShortcutsForCommonActions
Conversation
Contributor
|
Closing since this will likely need to be rewritten. |
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the groundwork to handle Bluetooth Keyboard shortcuts. I only implemented the
New tabshortcut on purpose, to first validate my approach, then implement the rest of the shortcuts.Basically, any UIResponder (views and view controllers) can implement a handler for a keyboard event. To do that, it should conform to the BluetoothKeyboardDelegate protocol, declare itself as able to become firstResponder and implement the desired delegate method(s).
For each keyboard event that we support, only the delegate method of the firstResponder BluetoothKeyboardDelegate will be called (if there's any).