Fixes 1192462 - Augment import-locales.sh and/or update-xliff.py#915
Merged
Fixes 1192462 - Augment import-locales.sh and/or update-xliff.py#915
Conversation
scripts/import-locales.sh
Outdated
Contributor
There was a problem hiding this comment.
What about using an array for readability?
INCOMPLETE_LOCALES=(
"da"
"eo"
"es"
"gl"
"is"
"ko"
"lt"
"ru"
"sk"
"son"
"tl"
"uz"
"zh-CN"
"zh-TW"
)
for i in "${!INCOMPLETE_LOCALES[@]}"; do
rm -rf firefox-ios-l10n/${INCOMPLETE_LOCALES[$i]}
done
Contributor
Author
There was a problem hiding this comment.
Thank you that looks nice. I am not a great shell scripter.
…llow the list of included locales to be specified
st3fan
force-pushed
the
st3fan/Bug1192462OnlyImportCompleteLocales
branch
from
5c3f3f5 to
5dddf76
Compare
st3fan
added a commit
that referenced
this pull request
Aug 12, 2015
…eteLocales Fixes 1192462 - Augment import-locales.sh and/or update-xliff.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change to
import-locales.shadds a--only-completeflag to the script. If this is specified then the script will remove locales that are not complete, after checking out the initial l10n repository.To keep things simple, the list of incomplete locales is kept inside the script. This means that before we do a final build, this list needs to be updated. The best place to see what locales are ready to go is the [https://l10n.mozilla-community.org/~flod/webstatus/?product=firefox-ios](L10N Dashboard).