Conversation
Contributor
|
Ugh, KVO management is a pain. Rather than worrying about all this dynamic KVO registration based on restoring, what if |
Author
|
Ya that would probably work better. Guess it's similar to the originally approach I had where I just set the boolean flag on Browser |
sleroux
force-pushed
the
sleroux/Bug1194664-CrashRestoreSessionTests
branch
from
446b6ac to
8891c27
Compare
sleroux
pushed a commit
that referenced
this pull request
Aug 14, 2015
…essionTests Bug 1194664 - Add checks when adding/removing KVOURL observers on BVC
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a flag to keep track of when we've attached the KVOURL observer since it can be called in two different places. The crash was being caused by the web page restoring after the page was loaded. This scenario wouldn't happen for real since a restoration always conincides with a web view creation but added the checks regardless. Also wrapped the removal of the observer with a Try/catch block just in case.