-
Notifications
You must be signed in to change notification settings - Fork 15
Hani/Test URLs copied from address bar contain https tags #851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tracy-Walker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to create a new method, press_ctrl_key(). Instead use the preform_key_combo() method directly in your test.
as a side note: in the method you created, it doesn't direct the key combo to the Awesome Bar, as comment indicates. Focusing the Awesome Bar is done in your test, prior to calling this method method.
anyway, please remove the duplicated method. Other than that, this looks good.
perform_key_combo() method is used in some content context cases, so I had to create perform_key_combo_chrome() since I needed @context_chrome in my test. |
Addressed the request in a comment above.
* Test URLs copied from address bar contain https tags * URLs copied from address bar contain https tags * Edit test * Edit test name * edit test * changes * Edit perform_key_combo * Edit comments * edit code * Replace a function * Edit comment --------- Co-authored-by: Hani Yacoub <hani.yacoub@svadmins-MBP.lan>
Relevant Links
Bugzilla: 1993251
TestRail: 3028712
Description of Code / Doc Changes
Process Changes Required
Mark the relevant boxes:
pipenv install)Screenshots or Explanations
If you need to explain your code, do it here.
Comments or Future Work
Do we need to start another PR soon to address something you saw while working on this?
Workflow Checklist
Thank you!