Skip to content

Conversation

@sv-hyacoub
Copy link
Collaborator

@sv-hyacoub sv-hyacoub commented Oct 21, 2025

Relevant Links

Bugzilla: 1993251
TestRail: 3028712

Description of Code / Doc Changes

  • Add test case 3028712

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): _
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

If you need to explain your code, do it here.

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to create a new method, press_ctrl_key(). Instead use the preform_key_combo() method directly in your test.

as a side note: in the method you created, it doesn't direct the key combo to the Awesome Bar, as comment indicates. Focusing the Awesome Bar is done in your test, prior to calling this method method.

anyway, please remove the duplicated method. Other than that, this looks good.

@sv-hyacoub
Copy link
Collaborator Author

There is no need to create a new method, press_ctrl_key(). Instead use the preform_key_combo() method directly in your test.

perform_key_combo() method is used in some content context cases, so I had to create perform_key_combo_chrome() since I needed @context_chrome in my test.

@sv-hyacoub sv-hyacoub dismissed Tracy-Walker’s stale review October 30, 2025 14:55

Addressed the request in a comment above.

@sv-hyacoub sv-hyacoub merged commit dfde694 into main Oct 31, 2025
64 of 66 checks passed
@sv-hyacoub sv-hyacoub deleted the Hani/url-copy-contains-https branch October 31, 2025 16:54
Sangie50 pushed a commit that referenced this pull request Nov 3, 2025
* Test URLs copied from address bar contain https tags

* URLs copied from address bar contain https tags

* Edit test

* Edit test name

* edit test

* changes

* Edit perform_key_combo

* Edit comments

* edit code

* Replace a function

* Edit comment

---------

Co-authored-by: Hani Yacoub <hani.yacoub@svadmins-MBP.lan>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants