Skip to content

Hani/ Fix test-search-suggesions #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
Merged

Hani/ Fix test-search-suggesions #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions SELECTOR_INFO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,16 +663,16 @@ Location: about:preferences#search
Path to .json: modules/data/about_prefs.components.json
```
```
Selector Name: firefox-suggest-nonsponsored
Selector Data: "firefoxSuggestNonsponsored"
Selector Name: firefox-suggestions
Selector Data: showSearchSuggestionsFirstCheckbox
Description: The Suggestions from Firefox check-box
Location: about:preferences#search > Address Bar - Firefox Suggest
Path to .json: modules/data/about_prefs.components.json
```
```
Selector Name: firefox-suggest-sponsored
Selector Data: "firefoxSuggestSponsored"
Description: The Suggestions from sponsors check-box
Selector Name: firefox-trending-suggestions
Selector Data: showTrendingSuggestions
Description: Trending search suggestions check-box
Location: about:preferences#search > Address Bar - Firefox Suggest
Path to .json: modules/data/about_prefs.components.json
```
Expand Down
8 changes: 4 additions & 4 deletions modules/data/about_prefs.components.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,13 +201,13 @@
"strategy": "id",
"groups": []
},
"firefox-suggest-nonsponsored": {
"selectorData": "firefoxSuggestNonsponsored",
"firefox-suggestions": {
"selectorData": "showSearchSuggestionsFirstCheckbox",
"strategy": "id",
"groups": []
},
"firefox-suggest-sponsored": {
"selectorData": "firefoxSuggestSponsored",
"firefox-trending-suggestions": {
"selectorData": "showTrendingSuggestions",
"strategy": "id",
"groups": []
},
Expand Down
8 changes: 4 additions & 4 deletions tests/address_bar_and_search/test_search_suggestions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,14 @@ def test_search_suggests_enabled(driver: Firefox):
if not suggestions_checkbox.is_selected():
suggestions_checkbox.click()

nonsponsored_checkbox = prefs.get_element("firefox-suggest-nonsponsored")
nonsponsored_checkbox = prefs.get_element("firefox-suggestions")
assert nonsponsored_checkbox.is_selected(), (
"'firefox-suggest-nonsponsored' checkbox not checked"
"'firefox-suggestions' checkbox not checked"
)

sponsored_checkbox = prefs.get_element("firefox-suggest-sponsored")
sponsored_checkbox = prefs.get_element("firefox-trending-suggestions")
assert sponsored_checkbox.is_selected(), (
"'firefox-suggest-sponsored' checkbox not checked"
"'firefox-trending-suggestions' checkbox not checked"
)

# Check for sponsored suggestion
Expand Down