Skip to content

Anca/ Fix addon-suggestion #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2025
Merged

Anca/ Fix addon-suggestion #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaa7456
Fix addon-suggestion
soncuteanca Nov 13, 2025
53688c0
Update list
soncuteanca Nov 14, 2025
36e4cdb
Reduce the wait time
soncuteanca Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/browser_object_autofill_popup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,5 +141,6 @@ def verify_update_password_doorhanger(self, nav, expected_text):

# Verify the doorhanger text
self.expect(
lambda _: expected_text in self.get_element("password-update-doorhanger").text
lambda _: expected_text
in self.get_element("password-update-doorhanger").text
)
4 changes: 2 additions & 2 deletions modules/page_object_autofill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,8 +860,8 @@ def generate_secure_password(self, context_menu):
# Wait until the password field is actually filled
self.parent.expect(
lambda _: (
(elem := self.parent.get_element("password-login-field"))
and elem.get_attribute("value") not in ("", None)
(elem := self.parent.get_element("password-login-field"))
and elem.get_attribute("value") not in ("", None)
)
)

Expand Down
13 changes: 6 additions & 7 deletions tests/address_bar_and_search/test_addon_suggestion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,16 @@

from modules.browser_object import Navigation

WAIT_TIMEOUT = 10
ADDONS_BASE_URL = "https://addons.mozilla.org/en-US/firefox/addon/"

# pending answers from search team about FX changes here, only grammar works as before
INPUT_TO_ADDON_NAME = {
"clips": "video-downloadhelper",
"video download": "video-downloadhelper",
"grammar": "languagetool",
"Temp mail": "private-relay",
"pics search": "search_by_image",
"alias": "private-relay",
"image finder": "search_by_image",
"darker theme": "darkreader",
"privacy": "privacy-badger17",
"read aloud": "read-aloud",
"accessibility reade": "read-aloud",
}


Expand All @@ -28,7 +27,7 @@ def test_case():
@pytest.mark.noxvfb
def test_addon_suggestion_based_on_search_input(driver: Firefox):
"""
C2234714 - Verify that the address bar suggests relevant add-ons based on search input.
C3029292 - Verify that the address bar suggests relevant add-ons based on search input.
"""
nav = Navigation(driver)
nav.set_awesome_bar()
Expand Down
4 changes: 1 addition & 3 deletions tests/password_manager/test_auto_saved_generated_password_context_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ def test_auto_saved_generated_password_context_menu(driver: Firefox):
login_autofill.LoginForm(login_autofill).generate_secure_password(context_menu)

# Verify the update doorhanger is displayed
autofill_popup_panel.verify_update_password_doorhanger(
nav, UPDATE_DOORHANGER_TEXT
)
autofill_popup_panel.verify_update_password_doorhanger(nav, UPDATE_DOORHANGER_TEXT)

# Navigate to about:logins page
tabs.switch_to_new_tab()
Expand Down