Skip to content

Conversation

@soncuteanca
Copy link
Collaborator

@soncuteanca soncuteanca commented Nov 27, 2025

Relevant Links

Bugzilla: 2000177
TestRail: 3028901

Description of Code / Doc Changes

  • Add test for delete history from url bar completion list
  • Add 2 methods in navigation
  • Modify description existing selector
  • added test_selectors: unstable to key.yaml, is present in all.yaml (the only discrepancy), but not in key, and got into a CI error

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): _
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

If you need to explain your code, do it here.

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

Tracy-Walker
Tracy-Walker previously approved these changes Dec 1, 2025
Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change method name of def verify_history_item_not_exists to def verify_history_item_does_not_exist

Otherwise looks good.

Copy link
Collaborator

@vsangereanMOZ vsangereanMOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@soncuteanca soncuteanca merged commit c2cda5e into main Dec 2, 2025
15 checks passed
@soncuteanca soncuteanca deleted the anca/delete-entry-via-url branch December 2, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants