fix(test): #321 Correct promises error handling

[deeptibaghel]

Fixed and tested all problematic promised error handling calls. One modified non-existing api call was getting caught at incorrect place due to the issue. Fixed the api call at two places.

[deeptibaghel]

r? @eoger

[eoger]

This looks great, thank you!
For some reason I can't leave comments on unchanged lines: I found some places where we are still relying on the bad pattern on lines:
918 - 971 - 1014 - 1177 - 1347
1363-1379 (can be in a top level then())

[deeptibaghel]

@eoger 918 - 971 - 1014 - 1177 - 1347 is done.
could you pl. mark this block : "1363-1379 (can be in a top level then())"

[eoger]

Thanks!

could you pl. mark this block : "1363-1379 (can be in a top level then())"

This block could be a top-level block. Same for this one.

[eoger]

Awesome work thank you!

[deeptibaghel]

Thanks a lot @eoger :)