This repository was archived by the owner on Apr 3, 2019. It is now read-only.
fix(codes): drop all codes when one is consumed #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
rfk
approved these changes
Mar 21, 2018
Contributor
rfk
left a comment
rfk
left a comment
There was a problem hiding this comment.
Looks good to me! Did you happen to test an auth-server with this change to see if it causes any test bustage over there? If not, let's keep an eye on auth-server CI just in case.
vladikoff
force-pushed
the
bz1368827
branch
2 times, most recently
from
7a09b7b to
9eda413
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rfk r?