feat(sentry): move sentry release version to front-end (#4220) r=vbudhram

Fixes #3474

Author: vladikoff

app/scripts/lib/app-start.js

@@ -172,7 +172,11 @@ define(function (require, exports, module) {
     },
 
     enableSentryMetrics () {
-      this._sentryMetrics = new SentryMetrics(this._window.location.host);
+      let release;
+      if (this._config && this._config.release) {
+        release = this._config.release;
+      }
+      this._sentryMetrics = new SentryMetrics(this._window.location.host, release);
     },
 
     initializeL10n () {

app/scripts/lib/sentry.js

@@ -130,10 +130,12 @@ define(function (require, exports, module) {
    * Read more at https://github.com/getsentry/raven-js
    *
    * @param {String} host
+   * @param {String} [release] - content server release version
    * @constructor
    */
-  function SentryMetrics (host) {
+  function SentryMetrics (host, release) {
     this._logger = new Logger();
+    this._release = release;
 
     if (host) {
       // use __API_KEY__ instead of the real API key because raven.js requires it
@@ -202,6 +204,11 @@ define(function (require, exports, module) {
         tags: tags
       };
 
+      if (this._release) {
+        // add release version if available
+        extraContext.release = this._release;
+      }
+
       Raven.captureException(err, extraContext);
     },
 

app/tests/spec/lib/sentry.js

@@ -208,8 +208,8 @@ define(function (require, exports, module) {
         // do not call the real captureException,
         // no need to make network requests.
         sandbox.stub(Raven, 'captureException', function () {});
-
-        var sentry = new SentryMetrics(host);
+        var release = '0.1.0';
+        var sentry = new SentryMetrics(host, release);
 
         var err = new Error('uh oh');
         err.code = 400;
@@ -222,6 +222,7 @@ define(function (require, exports, module) {
         sentry.captureException(err);
 
         assert.isTrue(Raven.captureException.calledWith(err, {
+          release: release,
           tags: {
             code: 400,
             context: '/signup',
@@ -233,6 +234,24 @@ define(function (require, exports, module) {
 
         sandbox.restore();
       });
+
+      it('reports the error even if release version is not set', function () {
+        var sandbox = sinon.sandbox.create();
+        sandbox.stub(Raven, 'captureException', function () {});
+        var sentry = new SentryMetrics(host);
+
+        var err = new Error('uh oh');
+        err.code = 400;
+
+        sentry.captureException(err);
+        assert.isTrue(Raven.captureException.calledWith(err, {
+          tags: {
+            code: 400
+          }
+        }));
+
+        sandbox.restore();
+      });
     });
 
     describe('shouldSendCallback', function () {

server/lib/routes/get-index.js

@@ -15,6 +15,8 @@ module.exports = function (config) {
   var OAUTH_SERVER_URL = config.get('oauth_url');
   var PROFILE_SERVER_URL = config.get('profile_url');
   var STATIC_RESOURCE_URL = config.get('static_resource_url');
+  // add version from package.json to config
+  var RELEASE = require('../../../package.json').version;
 
   var serializedConfig = encodeURIComponent(JSON.stringify({
     allowedParentOrigins: ALLOWED_PARENT_ORIGINS,
@@ -24,7 +26,8 @@ module.exports = function (config) {
     marketingEmailServerUrl: MARKETING_EMAIL_API_URL,
     oAuthClientId: CLIENT_ID,
     oAuthUrl: OAUTH_SERVER_URL,
-    profileUrl: PROFILE_SERVER_URL
+    profileUrl: PROFILE_SERVER_URL,
+    release: RELEASE
   }));
 
   var route = {};

server/lib/routes/post-metrics-errors.js

@@ -13,7 +13,6 @@ var sentryConfig = config.get('sentry');
 var API_KEY = sentryConfig.api_key;
 var API_SECRET = sentryConfig.api_secret;
 var STACK_TRACE_LENGTH = 20;
-var CONTENT_SERVER_VERSION = require('../../../package.json').version;
 
 /**
  * Attaches extra tags to sentry data
@@ -30,8 +29,6 @@ function setExtraSentryData(data) {
   }
 
   if (sentryData) {
-    sentryData.release = CONTENT_SERVER_VERSION;
-
     if (sentryData.stacktrace && sentryData.stacktrace.frames) {
       // the limit for the sentryRequest is controlled by nginx,
       // by default the request url should not be greater than ~8000 characters.