fix(confirm): change resend email limit to first 4 attempts (#3816) r=vbudhram

Fixes #3777

Author: vladikoff

app/scripts/models/email-resend.js

@@ -11,7 +11,7 @@ define(function (require, exports, module) {
   var Constants = require('lib/constants');
 
   function shouldResend (tries, maxTries) {
-    return tries === 1 || tries === maxTries;
+    return tries <= maxTries;
   }
 
   var EmailResend = Backbone.Model.extend({

app/tests/spec/models/email-resend.js

@@ -78,15 +78,15 @@ define(function (require, exports, module) {
     });
 
     describe('shouldResend', function () {
-      it('it returns true to the 1st and 4th try only', function () {
+      it('it returns true to the first 4 tries only', function () {
         emailResend = new EmailResend();
-        assert.isFalse(emailResend.shouldResend());
+        assert.isTrue(emailResend.shouldResend());
         emailResend.incrementRequestCount();
         assert.isTrue(emailResend.shouldResend());
         emailResend.incrementRequestCount();
-        assert.isFalse(emailResend.shouldResend());
+        assert.isTrue(emailResend.shouldResend());
         emailResend.incrementRequestCount();
-        assert.isFalse(emailResend.shouldResend());
+        assert.isTrue(emailResend.shouldResend());
         emailResend.incrementRequestCount();
         assert.isTrue(emailResend.shouldResend());
         for (var i = 0; i < 10; i++) {

app/tests/spec/views/confirm.js

@@ -334,7 +334,7 @@ define(function (require, exports, module) {
         assert.equal(count, 1);
       });
 
-      it('debounces resend calls - submit on first and forth attempt', function () {
+      it('debounces resend calls - submit on first four attempts', function () {
         var count = 0;
 
         sinon.stub(account, 'retrySignUp', function () {
@@ -345,15 +345,18 @@ define(function (require, exports, module) {
         return view.validateAndSubmit()
               .then(function () {
                 assert.equal(count, 1);
+                assert.equal(view.$('#resend:visible').length, 1);
                 return view.validateAndSubmit();
               }).then(function () {
-                assert.equal(count, 1);
+                assert.equal(count, 2);
+                assert.equal(view.$('#resend:visible').length, 1);
                 return view.validateAndSubmit();
               }).then(function () {
-                assert.equal(count, 1);
+                assert.equal(count, 3);
+                assert.equal(view.$('#resend:visible').length, 1);
                 return view.validateAndSubmit();
               }).then(function () {
-                assert.equal(count, 2);
+                assert.equal(count, 4);
                 assert.equal(view.$('#resend:visible').length, 0);
 
                 assert.isTrue(TestHelpers.isEventLogged(metrics,

app/tests/spec/views/confirm_reset_password.js

@@ -590,7 +590,7 @@ define(function (require, exports, module) {
         assert.equal(count, 1);
       });
 
-      it('debounces resend calls - submit on first and forth attempt', function () {
+      it('debounces resend calls - submit on first four attempts', function () {
         sinon.stub(view, 'retryResetPassword', function () {
           return p(true);
         });
@@ -600,13 +600,13 @@ define(function (require, exports, module) {
                 assert.equal(view.retryResetPassword.callCount, 1);
                 return view.validateAndSubmit();
               }).then(function () {
-                assert.equal(view.retryResetPassword.callCount, 1);
+                assert.equal(view.retryResetPassword.callCount, 2);
                 return view.validateAndSubmit();
               }).then(function () {
-                assert.equal(view.retryResetPassword.callCount, 1);
+                assert.equal(view.retryResetPassword.callCount, 3);
                 return view.validateAndSubmit();
               }).then(function () {
-                assert.equal(view.retryResetPassword.callCount, 2);
+                assert.equal(view.retryResetPassword.callCount, 4);
                 assert.equal(view.$('#resend:visible').length, 0);
 
                 assert.isTrue(TestHelpers.isEventLogged(metrics,