chore(python_server): replace print with sys.stdout.write #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because print writes the ping and newline separately, which increases the chances of something else, like another ping, getting printed between them
Contributor
Author
|
cc @akkomar |
akkomar
approved these changes
Nov 6, 2025
Collaborator
akkomar
left a comment
akkomar
left a comment
There was a problem hiding this comment.
TIL!, IIUC it's happening here.
I think this is acceptable workaround.
Ideally we would use mozlog. For some reason I don't remember with the first consumer that used this (Relay) we opted to default to print and allow application to override this. Let's talk about this when we meet later today.
This was referenced Nov 10, 2025
Contributor
Author
|
@akkomar anything i can do to help move this forward? I'd like to update experimenter and cirrus to use this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because print writes the ping and newline separately, which increases the chances of something else, like another ping, getting printed between them.
This was trialed in experimenter and fixed the issue with double-pings showing up in the logs.
Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one