Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

bug 1218563: Document building/updating base img#3992

Merged
jwhitlock merged 1 commit intomdn:masterfrom
jgmize:doc-build-base-latest
Sep 27, 2016
Merged

bug 1218563: Document building/updating base img#3992
jwhitlock merged 1 commit intomdn:masterfrom
jgmize:doc-build-base-latest

Conversation

@jgmize
Copy link
Copy Markdown
Contributor

@jgmize jgmize commented Sep 27, 2016

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 27, 2016

Current coverage is 86.23% (diff: 100%)

Merging #3992 into master will not change coverage

@@             master      #3992   diff @@
==========================================
  Files           145        145          
  Lines          8836       8836          
  Methods           0          0          
  Messages          0          0          
  Branches       1188       1188          
==========================================
  Hits           7620       7620          
  Misses          976        976          
  Partials        240        240          

Powered by Codecov. Last update cb93fa8...df1e1e4

Copy link
Copy Markdown
Contributor

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions worked, but I missed the intent the first time. I ran the first instruction, then the second, and had my freshly-built base image replaced with the cloud version. Luckily, the local build was completely cached, so it was fast to recover.

Can you add a make up or similar in the middle, to signal how to recreate the containers with the fresh base image?

@jgmize jgmize force-pushed the doc-build-base-latest branch from 0090fb2 to df1e1e4 Compare September 27, 2016 18:50
@jgmize
Copy link
Copy Markdown
Contributor Author

jgmize commented Sep 27, 2016

updated with instructions to restart the containers to start using the newly built base image. Note that I explicitly documented docker-compose stop and docker-compose up -d as separate steps because I have seen issues with docker-compose restart and do not recommend it.

@jwhitlock jwhitlock merged commit 48fb8f5 into mdn:master Sep 27, 2016
@jwhitlock
Copy link
Copy Markdown
Contributor

Thanks @jgmize this is much better than the method I was using to use a locally-built image.

@jgmize jgmize deleted the doc-build-base-latest branch September 27, 2016 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants