This repository was archived by the owner on Aug 26, 2022. It is now read-only.
Bug 879839 - Remove Summary style, rename SEO Summary option #5154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the "Summary" style we've decided not to use anymore and renames the existing SEO summary option to simply "Summary", per discussion held on Discourse: https://is.gd/ss9I6r
Contributor
Author
|
This could use a quick review. Perhaps from @escattone or @schalkneethling, or even @chrisdavidmills. |
schalkneethling
left a comment
schalkneethling
left a comment
There was a problem hiding this comment.
One suggestion. Other than that r+w/c Thanks @a2sheppy 🎉
Contributor
Author
|
Pending re-review by @schalkneethling. |
a2sheppy
pushed a commit
to a2sheppy/kuma
that referenced
this pull request
Jan 10, 2019
In PR mdn#5154, the name of the seoSummary class was changed in the CKEditor menu to just "Summary". This patch makes the same change to the CSS that is used to display the style when in the editor, so that the label drawn above the styled content says that instead of "SEO Summary".
schalkneethling
pushed a commit
that referenced
this pull request
Jan 11, 2019
In PR #5154, the name of the seoSummary class was changed in the CKEditor menu to just "Summary". This patch makes the same change to the CSS that is used to display the style when in the editor, so that the label drawn above the styled content says that instead of "SEO Summary".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the "Summary" style we've decided not to
use anymore and renames the existing SEO summary
option to simply "Summary", per discussion held on Discourse:
https://is.gd/ss9I6r