Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Revert "Bug 1423716: stop adding the SEO root title to all document titles"#5226

Merged
jwhitlock merged 1 commit intomdn:masterfrom
davidflanagan:revert-bug-1423716
Jan 31, 2019
Merged

Revert "Bug 1423716: stop adding the SEO root title to all document titles"#5226
jwhitlock merged 1 commit intomdn:masterfrom
davidflanagan:revert-bug-1423716

Conversation

@davidflanagan
Copy link

This reverts commits ff5f81e
and 5fdf95c.

@davidflanagan
Copy link
Author

The failing test is a lint failure in files I did not change...

Copy link
Contributor

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job bringing back the function test fixes as well @davidflanagan

# the SEO root title does *not* appear in document titles.
def test_no_seo_title(self):
def test_get_seo_parent_doesnt_throw_404(self):
"""bug 1190212"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment for bug 1190212 is back 😢

@jwhitlock jwhitlock merged commit 5cf16a1 into mdn:master Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants