Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

bug 1534804: Avoid prepending anchors on edit page#5298

Merged
schalkneethling merged 1 commit intomdn:masterfrom
jwhitlock:anchor-edit-1534804
Mar 13, 2019
Merged

bug 1534804: Avoid prepending anchors on edit page#5298
schalkneethling merged 1 commit intomdn:masterfrom
jwhitlock:anchor-edit-1534804

Conversation

@jwhitlock
Copy link
Copy Markdown
Contributor

On the edit page, there is no element with ID document-main, so an error is raised when adding the click event listener. When the lookup fails, skip the work to add anchors for linking.

On the edit page, there is no element with ID document-main, so a error
is raised when adding the click event listener. When the lookup fails,
skip the work to add anchors for linking.
Copy link
Copy Markdown
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @jwhitlock

Copy link
Copy Markdown

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@schalkneethling schalkneethling merged commit 803f922 into mdn:master Mar 13, 2019
@jwhitlock jwhitlock deleted the anchor-edit-1534804 branch March 27, 2019 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants