This repository was archived by the owner on Jun 21, 2022. It is now read-only.
Closed
Conversation
Change jsxref macro to use <%- %> for the displayed text, so that special characters like "<" and ">" draw correctly instead of showing up as "<" etc.
Contributor
|
The text should be not be escaped if the to produce: |
Elchi3
suggested changes
Feb 9, 2017
Member
Elchi3
left a comment
There was a problem hiding this comment.
I think John's proposal makes sense. Setting "request changes".
…he link. DOES NOT YET WORK.
Elchi3
approved these changes
Feb 9, 2017
jwhitlock
reviewed
Feb 9, 2017
Contributor
jwhitlock
left a comment
There was a problem hiding this comment.
When I run this locally:
jsxref 1: {{jsxref("Ops", ">", "#Less_than_operator")}}
jsxref 2: {{jsxref("Ops", ">", "#Less", 0)}}
I get the following HTML:
<p>jsxref 1: <a title="The documentation about this has not yet been written; please consider contributing!" class="new" href="/en-US/docs/Web/JavaScript/Reference/Ops#Less_than_operator"><code>
>
</code></a></p>
<p>jsxref 2: <a title="The documentation about this has not yet been written; please consider contributing!" class="new" href="/en-US/docs/Web/JavaScript/Reference/Ops#Less">
&gt;
</a></p>
I think the first version, that just used <%- str %>, might actually be right for both cases.
Contributor
|
Manually merged the first commit to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change jsxref macro to use <%- %> for the displayed text, so that special
characters like "<" and ">" draw correctly instead of showing up as "<"
etc.