Convert most resources to use ResourceLoader #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some compatibility issues between this module and modern MediaWiki's, namely around jQuery and jQueryUI. Without this, the Bugzilla tables shown are offset to the right due to improperly formatted CSS. This extension loads an jQuery plugin (DataTables) that does the pagination, which necessitates this being placed in "top" instead of the default "bottom". Better might be to install the actual MW extension that someone has created just for this (http://www.mediawiki.org/wiki/Extension:DataTables), but that's a bit larger scope and I'm not quite ready to go that far just yet. Tested and working on wiki-dev.allizom.org, though I have not significantly looked for regressions.
Contributor
Author
|
Perhaps @hexmode, or @christi3k could look this over and give a thumbs-up or thumbs-down? I am not a PHP dev (let alone a MW dev), so this may need some cleaning up. |
Contributor
|
Code looks okay to me. I'm not able to verify the fix on dev, though. Has the patch been applied there? |
Contributor
|
Patch has been reapplied to dev. Looks good. r+ |
rhelmer
added a commit
that referenced
this pull request
Apr 28, 2014
Convert most resources to use ResourceLoader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some compatibility issues between this module and modern MediaWiki's, namely around jQuery and jQueryUI. Without this, the Bugzilla tables shown are offset to the right due to improperly formatted CSS.
This extension loads an jQuery plugin (DataTables) that does the pagination, which necessitates this being placed in "top" instead of the default "bottom".
Better might be to install the actual MW extension that someone has created just for this (http://www.mediawiki.org/wiki/Extension:DataTables), but that's a bit larger scope and I'm not quite ready to go that far just yet.
Tested and working on wiki-dev.allizom.org, though I have not significantly looked for regressions.