Skip to content

Bug 1184915 - fix 'InboundBuildData' object has no attribute 'raw_revisions' #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Bug 1184915 - fix 'InboundBuildData' object has no attribute 'raw_revisions' #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions mozregression/bisector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,10 +559,11 @@ def bisect_inbound(self, good_rev, bad_rev):
# NO_DATA
self._logger.info("No inbound data found.")
# check if we have found revisions
if handler.build_data.raw_revisions:
if not handler.build_data.was_empty():
# if we have, then these builds are probably too old
self._logger.info('There are no build dirs on inbound for'
' these changesets.')
self._logger.info(
'There are no build artifacts on inbound for these'
' changesets (these are probably too old).')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are probably -> they are probably

return 1
return 0

Expand Down
5 changes: 5 additions & 0 deletions mozregression/build_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,10 @@ def __init__(self, fetch_config, start_rev, end_rev):
self._logger.debug('Found %d pushlog entries using `%s`'
% (len(pushlogs), pushlogs_finder.pushlog_url()))

self._was_empty = False
if len(pushlogs) < 2:
# if we have 0 or 1 pushlog entry, we can not bisect.
self._was_empty = True
return

cache = []
Expand All @@ -402,6 +404,9 @@ def __init__(self, fetch_config, start_rev, end_rev):

self.info_fetcher = BuildFolderInfoFetcher(None, None)

def was_empty(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I don't see the point of the wrapper method here -- can you not just read/write was_empty directly?

I'd at least make it a property, so you don't have to call the function.

return self._was_empty

def _get_valid_build(self, i):
changeset = self.get_associated_data(i)[0]
tk_route = self.fetch_config.tk_inbound_route(changeset)
Expand Down