Skip to content

Conversation

@parkouss
Copy link
Contributor

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might consider making this class inherit from list, and just adding one or two custom methods for convenience. Something like:

class BisectionHistory(list):
    def add_step(self, build_range, index, verdict):
        self.append(BisectionStep(...))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

@parkouss parkouss merged commit 7680d29 into mozilla:master Nov 20, 2015
@parkouss parkouss deleted the fix-back-skip branch December 3, 2015 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants