add express for heroku deploy #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimberlythegeek
requested review from
beatrice-acasandrei,
eng-esther and
esanuandra
kimberlythegeek
force-pushed
the
fix/heroku-deploy-express
branch
from
d4f8be8 to
a103a13
Compare
beatrice-acasandrei
approved these changes
Aug 11, 2022
kimberlythegeek
added a commit
that referenced
this pull request
Aug 23, 2022
kimberlythegeek
added a commit
that referenced
this pull request
Aug 23, 2022
* * update CI to run on master and staging nightly (#173) * update readme contributing guide * automatically create PR to merge staging to master once per week (#178) * Revert "automatically create PR to merge staging to master once per week (#178)" (#179) This reverts commit 5c7b491. * add popover to edit revision on results view (#182) * add graph column to compare results table * update snapshot for compare results * Add aria-label, add :hover for graph link * improve ui of edit revision ui (#196) * eject from react-scripts and update to react 18 (#198) * updated packages and included ones added by ejecting the app * added configurations for webpack and included config files in eslint * created separate jest config file * * moved .babelsrc to root directory * updated babel config to target 2 most recent chrome and firefox versions * added babel-plugin-transform-runtime to avoid duplication * * removed auto-generated manifest file * removed leftover comments from create-react-app * removed %PUBLIC_URL% from paths as this is no longer needed * updated tsconfig options * * created typed hooks for useDispatch and useSelector * add `void` to fix some typescript errors * updates required by React 18 * updated tests for compatibility * updated material imports to improve performance * updated readme * replace usage of useSelector with typed hook useAppSelector (#203) * use typed hooks * remove State type and replace with RootState * add express for heroku deploy (#204) * add missing packages and update lock file (#212) * change icon size make graph icon more obvious that its a link * add mock graphs link data and to the table * store revision instead of index in checkedRevisions state (#209) * edit revision ui (#214) * update lockfile (#217) * implement replace selected revision (#216) * update mock data with actual test results (#201) * open graph in new tab (#219) * add confidence icon * add muiIconButton style * remove question mark svg * add confidence icon * add confidence icon * add confidence icon * fix test * fix errors in accessibility test (#218) * fix errors in accessibility test * commented out test and added note explaining why Co-authored-by: esanuandra <andra.esanu@softvision.com> Co-authored-by: eng_esther <eitimielo@mozilla.com>
kimberlythegeek
added a commit
that referenced
this pull request
Sep 12, 2022
* * update CI to run on master and staging nightly (#173) * update readme contributing guide * automatically create PR to merge staging to master once per week (#178) * Revert "automatically create PR to merge staging to master once per week (#178)" (#179) This reverts commit 5c7b491. * add popover to edit revision on results view (#182) * add graph column to compare results table * update snapshot for compare results * Add aria-label, add :hover for graph link * improve ui of edit revision ui (#196) * eject from react-scripts and update to react 18 (#198) * updated packages and included ones added by ejecting the app * added configurations for webpack and included config files in eslint * created separate jest config file * * moved .babelsrc to root directory * updated babel config to target 2 most recent chrome and firefox versions * added babel-plugin-transform-runtime to avoid duplication * * removed auto-generated manifest file * removed leftover comments from create-react-app * removed %PUBLIC_URL% from paths as this is no longer needed * updated tsconfig options * * created typed hooks for useDispatch and useSelector * add `void` to fix some typescript errors * updates required by React 18 * updated tests for compatibility * updated material imports to improve performance * updated readme * replace usage of useSelector with typed hook useAppSelector (#203) * use typed hooks * remove State type and replace with RootState * add express for heroku deploy (#204) * add missing packages and update lock file (#212) * change icon size make graph icon more obvious that its a link * add mock graphs link data and to the table * store revision instead of index in checkedRevisions state (#209) * edit revision ui (#214) * update lockfile (#217) * implement replace selected revision (#216) * update mock data with actual test results (#201) * open graph in new tab (#219) * add confidence icon * add muiIconButton style * remove question mark svg * add confidence icon * add confidence icon * add confidence icon * fix test * fix errors in accessibility test (#218) * fix errors in accessibility test * commented out test and added note explaining why * replace mean with median (#228) * fix url routing issue (#221) * add measurement units (#227) * add mocking branch to heroku auto-deploy (#231) * [PerfCompare] Replace Test Name and Suite Name with Header Name Co-authored-by: esanuandra <andra.esanu@softvision.com> Co-authored-by: eng_esther <eitimielo@mozilla.com> Co-authored-by: bacasandrei <beatrice.raluca.acasandrei@gmail.com> Co-authored-by: beatrice-acasandrei <69891317+beatrice-acasandrei@users.noreply.github.com>
kimberlythegeek
added a commit
that referenced
this pull request
Sep 22, 2022
* Merge staging to master 08/22/2022 (#224) * * update CI to run on master and staging nightly (#173) * update readme contributing guide * automatically create PR to merge staging to master once per week (#178) * Revert "automatically create PR to merge staging to master once per week (#178)" (#179) This reverts commit 5c7b491. * add popover to edit revision on results view (#182) * add graph column to compare results table * update snapshot for compare results * Add aria-label, add :hover for graph link * improve ui of edit revision ui (#196) * eject from react-scripts and update to react 18 (#198) * updated packages and included ones added by ejecting the app * added configurations for webpack and included config files in eslint * created separate jest config file * * moved .babelsrc to root directory * updated babel config to target 2 most recent chrome and firefox versions * added babel-plugin-transform-runtime to avoid duplication * * removed auto-generated manifest file * removed leftover comments from create-react-app * removed %PUBLIC_URL% from paths as this is no longer needed * updated tsconfig options * * created typed hooks for useDispatch and useSelector * add `void` to fix some typescript errors * updates required by React 18 * updated tests for compatibility * updated material imports to improve performance * updated readme * replace usage of useSelector with typed hook useAppSelector (#203) * use typed hooks * remove State type and replace with RootState * add express for heroku deploy (#204) * add missing packages and update lock file (#212) * change icon size make graph icon more obvious that its a link * add mock graphs link data and to the table * store revision instead of index in checkedRevisions state (#209) * edit revision ui (#214) * update lockfile (#217) * implement replace selected revision (#216) * update mock data with actual test results (#201) * open graph in new tab (#219) * add confidence icon * add muiIconButton style * remove question mark svg * add confidence icon * add confidence icon * add confidence icon * fix test * fix errors in accessibility test (#218) * fix errors in accessibility test * commented out test and added note explaining why Co-authored-by: esanuandra <andra.esanu@softvision.com> Co-authored-by: eng_esther <eitimielo@mozilla.com> * add mocking branch to heroku auto-deploy (#231) * [PerfCompare] Replace Test Name and Suite Name with Header Name * unstable version warning (#239) * do not show search results when dropdown is clicked (#238) * Feedback icon + alert * update readme with deployment and feedback info (#245) * resolve production routing issue (#251) Co-authored-by: esanuandra <andra.esanu@softvision.com> Co-authored-by: eng_esther <eitimielo@mozilla.com> Co-authored-by: bacasandrei <beatrice.raluca.acasandrei@gmail.com> Co-authored-by: beatrice-acasandrei <69891317+beatrice-acasandrei@users.noreply.github.com>
kimberlythegeek
added a commit
that referenced
this pull request
Oct 17, 2022
* * update CI to run on master and staging nightly (#173) * update readme contributing guide * automatically create PR to merge staging to master once per week (#178) * Revert "automatically create PR to merge staging to master once per week (#178)" (#179) This reverts commit 5c7b491. * add popover to edit revision on results view (#182) * add graph column to compare results table * update snapshot for compare results * Add aria-label, add :hover for graph link * improve ui of edit revision ui (#196) * eject from react-scripts and update to react 18 (#198) * updated packages and included ones added by ejecting the app * added configurations for webpack and included config files in eslint * created separate jest config file * * moved .babelsrc to root directory * updated babel config to target 2 most recent chrome and firefox versions * added babel-plugin-transform-runtime to avoid duplication * * removed auto-generated manifest file * removed leftover comments from create-react-app * removed %PUBLIC_URL% from paths as this is no longer needed * updated tsconfig options * * created typed hooks for useDispatch and useSelector * add `void` to fix some typescript errors * updates required by React 18 * updated tests for compatibility * updated material imports to improve performance * updated readme * replace usage of useSelector with typed hook useAppSelector (#203) * use typed hooks * remove State type and replace with RootState * add express for heroku deploy (#204) * add missing packages and update lock file (#212) * change icon size make graph icon more obvious that its a link * add mock graphs link data and to the table * store revision instead of index in checkedRevisions state (#209) * edit revision ui (#214) * update lockfile (#217) * implement replace selected revision (#216) * update mock data with actual test results (#201) * open graph in new tab (#219) * add confidence icon * add muiIconButton style * remove question mark svg * add confidence icon * add confidence icon * add confidence icon * fix test * fix errors in accessibility test (#218) * fix errors in accessibility test * commented out test and added note explaining why * replace mean with median (#228) * fix url routing issue (#221) * add measurement units (#227) * add mocking branch to heroku auto-deploy (#231) * [PerfCompare] Replace Test Name and Suite Name with Header Name * unstable version warning (#239) * do not show search results when dropdown is clicked (#238) * Feedback icon + alert * update readme with deployment and feedback info (#245) * resolve production routing issue (#251) * fetch results from api (#236) * Create codecov.yml * Update codecov.yml * loading icon (#246) * pagination (#247) * [PerfCompare] disable comparing 1 revision, or more than 2, and display alert * Address change request * Adding one more check so that we don't allow more than four revisions * remove unused github actions (#259) * fix snapshot test after resolving merge conflict (#261) Co-authored-by: esanuandra <andra.esanu@softvision.com> Co-authored-by: eng_esther <eitimielo@mozilla.com> Co-authored-by: bacasandrei <beatrice.raluca.acasandrei@gmail.com> Co-authored-by: beatrice-acasandrei <69891317+beatrice-acasandrei@users.noreply.github.com>
kimberlythegeek
added a commit
that referenced
this pull request
Nov 7, 2022
* * update CI to run on master and staging nightly (#173) * update readme contributing guide * automatically create PR to merge staging to master once per week (#178) * Revert "automatically create PR to merge staging to master once per week (#178)" (#179) This reverts commit 5c7b491. * add popover to edit revision on results view (#182) * add graph column to compare results table * update snapshot for compare results * Add aria-label, add :hover for graph link * improve ui of edit revision ui (#196) * eject from react-scripts and update to react 18 (#198) * updated packages and included ones added by ejecting the app * added configurations for webpack and included config files in eslint * created separate jest config file * * moved .babelsrc to root directory * updated babel config to target 2 most recent chrome and firefox versions * added babel-plugin-transform-runtime to avoid duplication * * removed auto-generated manifest file * removed leftover comments from create-react-app * removed %PUBLIC_URL% from paths as this is no longer needed * updated tsconfig options * * created typed hooks for useDispatch and useSelector * add `void` to fix some typescript errors * updates required by React 18 * updated tests for compatibility * updated material imports to improve performance * updated readme * replace usage of useSelector with typed hook useAppSelector (#203) * use typed hooks * remove State type and replace with RootState * add express for heroku deploy (#204) * add missing packages and update lock file (#212) * change icon size make graph icon more obvious that its a link * add mock graphs link data and to the table * store revision instead of index in checkedRevisions state (#209) * edit revision ui (#214) * update lockfile (#217) * implement replace selected revision (#216) * update mock data with actual test results (#201) * open graph in new tab (#219) * add confidence icon * add muiIconButton style * remove question mark svg * add confidence icon * add confidence icon * add confidence icon * fix test * fix errors in accessibility test (#218) * fix errors in accessibility test * commented out test and added note explaining why * replace mean with median (#228) * fix url routing issue (#221) * add measurement units (#227) * add mocking branch to heroku auto-deploy (#231) * [PerfCompare] Replace Test Name and Suite Name with Header Name * unstable version warning (#239) * do not show search results when dropdown is clicked (#238) * Feedback icon + alert * update readme with deployment and feedback info (#245) * resolve production routing issue (#251) * fetch results from api (#236) * Create codecov.yml * Update codecov.yml * loading icon (#246) * pagination (#247) * [PerfCompare] disable comparing 1 revision, or more than 2, and display alert * Address change request * Adding one more check so that we don't allow more than four revisions * remove unused github actions (#259) * fix snapshot test after resolving merge conflict (#261) * Bumped version number to 0.9.0 Co-authored-by: esanuandra <andra.esanu@softvision.com> Co-authored-by: eng_esther <eitimielo@mozilla.com> Co-authored-by: bacasandrei <beatrice.raluca.acasandrei@gmail.com> Co-authored-by: beatrice-acasandrei <69891317+beatrice-acasandrei@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving to webpack in #198, the heroku deployment is no longer working, as it is trying to run webpack, which is a dev dependency.
added express to serve the production app. Heroku uses
npm startby default to run node apps, so I've added the scriptnpm run devto start the dev server.demo app to show that this fixed the problem: https://perfcompare-webpack.herokuapp.com/